Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Remove more files #19603

Merged
merged 2 commits into from
Jun 19, 2018
Merged

[build] Remove more files #19603

merged 2 commits into from
Jun 19, 2018

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented May 31, 2018 •
edited
Loading

This adds more globs to the list of files that get removed from node_modules.

Common files were found using find:

find node_modules -type f -not -name "*.js"| xargs -I{} basename {} | sort | uniq -c | sort

@jbudz jbudz self-assigned this May 31, 2018
@elasticmachine

This comment has been minimized.

Sign in to view
@jbudz

This comment has been minimized.

Sign in to view
@jbudz

This comment has been minimized.

Sign in to view
@jbudz

This comment has been minimized.

Sign in to view
@jbudz
Copy link
Member Author

jbudz commented May 31, 2018

Before:

mbp elastic/kibana ‹master*› » ls -lah target
total 3360048
drwxr-xr-x  10 jbudz  staff   320B May 31 15:42 .
drwxr-xr-x  50 jbudz  staff   1.6K May 31 15:38 ..
-rw-r--r--   1 jbudz  staff   312M May 31 15:39 kibana-7.0.0-alpha1-SNAPSHOT-darwin-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff   313M May 31 15:39 kibana-7.0.0-alpha1-SNAPSHOT-linux-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff   335M May 31 15:39 kibana-7.0.0-alpha1-SNAPSHOT-windows-x86_64.zip
-rw-r--r--   1 jbudz  staff    79M May 31 15:39 kibana-oss-7.0.0-alpha1-SNAPSHOT-darwin-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff    80M May 31 15:39 kibana-oss-7.0.0-alpha1-SNAPSHOT-linux-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff    94M May 31 15:39 kibana-oss-7.0.0-alpha1-SNAPSHOT-windows-x86_64.zip

After:
mbp elastic/kibana ‹build/cleanup*› » ls -lah target
total 3034016
drwxr-xr-x   9 jbudz  staff   288B May 31 16:20 .
drwxr-xr-x  50 jbudz  staff   1.6K May 31 16:18 ..
-rw-r--r--   1 jbudz  staff   295M May 31 16:18 kibana-7.0.0-alpha1-SNAPSHOT-darwin-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff   297M May 31 16:18 kibana-7.0.0-alpha1-SNAPSHOT-linux-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff   317M May 31 16:18 kibana-7.0.0-alpha1-SNAPSHOT-windows-x86_64.zip
-rw-r--r--   1 jbudz  staff    65M May 31 16:19 kibana-oss-7.0.0-alpha1-SNAPSHOT-darwin-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff    67M May 31 16:19 kibana-oss-7.0.0-alpha1-SNAPSHOT-linux-x86_64.tar.gz
-rw-r--r--   1 jbudz  staff    79M May 31 16:19 kibana-oss-7.0.0-alpha1-SNAPSHOT-windows-x86_64.zip

@elastic elastic deleted a comment from elasticmachine May 31, 2018
@jbudz jbudz added review discuss Team:Operations Team label for Operations Team labels May 31, 2018
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
epixa
epixa reviewed Jun 1, 2018
View reviewed changes
src/dev/build/tasks/clean_tasks.js Outdated
'*.sh',
'*.scss',
'*.sass',
'*.png',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that x-pack is now in node_modules on builds, so I don't think removing things like images is safe.

@jbudz
Copy link
Member Author

jbudz commented Jun 18, 2018

Last commit removed images and archives (chromium, phantom) from the patterns list, these can be added back with an exclude of the x-pack folder. Split tasks up so we don't OOM when the globs match too many files.

Letting CI run

@jbudz jbudz removed the discuss label Jun 18, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

epixa
epixa approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left some minor notes, but if there's any contention with them, don't hold this up.

src/dev/build/tasks/clean_tasks.js Outdated
'gulpfile.js',
'Makefile',
];
const transpiledSources = ['*.coffee', '*.scss', '*.sass'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The are the opposite of transpiled sources. They are untranspiled sources, or perhaps transpilable sources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add .ts and .tsx to the mix since those can't be transpiled on the fly?

Copy link
Member Author

@jbudz jbudz Jun 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Updated both with 9190f60

@jbudz jbudz requested a review from tylersmalley June 19, 2018 15:13
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

tylersmalley
tylersmalley approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested

@jbudz jbudz merged commit f40dbd0 into elastic:master Jun 19, 2018
jbudz added a commit to jbudz/kibana that referenced this pull request Jun 19, 2018
@jbudz
[build] Remove more files (elastic#19603)
89ed4b7 
* [build] Remove more files

* rename, add ts and tsx
jbudz added a commit that referenced this pull request Jun 19, 2018
@jbudz
[build] Remove more files (#19603) (#20054)
fe1e88a 
* [build] Remove more files

* rename, add ts and tsx
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
@jbudz @maryia-lapata
[build] Remove more files (elastic#19603)
7145a3a 
* [build] Remove more files

* rename, add ts and tsx
@jbudz jbudz mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epixa epixa epixa approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees

@jbudz jbudz

Labels
review Team:Operations Team label for Operations Team v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbudz @elasticmachine @tylersmalley @epixa